Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [RFC PATCH 4/8] thp: Add thp_get_unmapped_area_vmflags() | Date | Fri, 16 Feb 2024 22:21:13 +0000 |
| |
On Fri, 2024-02-16 at 14:59 +0200, Kirill A. Shutemov wrote: > On Thu, Feb 15, 2024 at 03:13:28PM -0800, Rick Edgecombe wrote: > > +unsigned long thp_get_unmapped_area(struct file *filp, unsigned > > long addr, > > + unsigned long len, unsigned long pgoff, unsigned > > long flags) > > +{ > > + return thp_get_unmapped_area_vmflags(filp, addr, len, > > pgoff, flags, 0); > > } > > EXPORT_SYMBOL_GPL(thp_get_unmapped_area); > > Again, static inline should be fine.
Not sure if the diff might be a bit misleading here, the signature of thp_get_unmapped_area() didn't actually change.
If thp_get_unmapped_area() is made into a static inline, then thp_get_unmapped_area_vmflags() would need to be exported instead so it could be used in some modules. Unlike get_unmapped_area() thp_get_unmapped_area is actually is used that way.
Better to export the more limited version?
| |