Messages in this thread | | | From | "Elliott, Robert (Servers)" <> | Subject | RE: [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters | Date | Fri, 16 Feb 2024 18:48:14 +0000 |
| |
> -----Original Message----- > From: Stefan Berger <stefanb@linux.ibm.com> > Sent: Thursday, February 15, 2024 5:14 PM > Subject: [PATCH v2 06/14] crypto: ecc - Add NIST P521 curve parameters > > Add the parameters for the NIST P521 curve and define a new curve ID > for it. Make the curve available in ecc_get_curve. > .. > diff --git a/crypto/ecc_curve_defs.h b/crypto/ecc_curve_defs.h .. > +static struct ecc_curve nist_p521 = { > + .name = "nist_521",
Are the name fields in the ecc_curve structures used anywhere or exposed to userspace?
It'd be nice if the strings for the nist_p192, nist_p256, and nist_p384 structures and this new nist_p521 structure included "p" before the number, better matching all the code and the NIST FIPS 186-4 names: .name = "nist_p192" .name = "nist_p256" .name = "nist_p384" .name = "nist_p521"
| |