lkml.org 
[lkml]   [2024]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save()
From
Date
On Thu, 2024-02-15 at 15:55 -0800, Andrew Morton wrote:
> + * This function marks the beginning of the __GFP_MEMALLOC allocation scope.
> > ...
> >
> > + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope.
>
> pet peeves. We can assume that the reader knows that this is a
> function! Perhaps we should teach checkpatch to whine.
>
> Like "the function foo" and "the function foo()" in changelogs.
> "foo()" is enough!

IMO: checkpatch should not be a grammar checker.

It's stupid enough as is let alone trying to get
it to analyze sentence structure.


\
 
 \ /
  Last update: 2024-05-27 15:07    [W:0.049 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site