Messages in this thread | | | Subject | Re: [PATCH v2] mm: document memalloc_noreclaim_save() and memalloc_pin_save() | From | Joe Perches <> | Date | Fri, 16 Feb 2024 10:04:16 -0800 |
| |
On Thu, 2024-02-15 at 15:55 -0800, Andrew Morton wrote: > + * This function marks the beginning of the __GFP_MEMALLOC allocation scope. > > ... > > > > + * This function marks the beginning of the ~__GFP_MOVABLE allocation scope. > > pet peeves. We can assume that the reader knows that this is a > function! Perhaps we should teach checkpatch to whine. > > Like "the function foo" and "the function foo()" in changelogs. > "foo()" is enough!
IMO: checkpatch should not be a grammar checker.
It's stupid enough as is let alone trying to get it to analyze sentence structure.
| |