lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations
    On Thu, Feb 15, 2024 at 04:17:58PM +0100, Thomas Richard wrote:
    > Even if a PHY is already configured, the PHY operations are needed during
    > resume stage, as the PHY is in reset state.
    > The noop_ops PHY operations is removed to always have PHY operations.
    > The already_configured flag is checked at the begening of init, configure
    > and poweron operations to keep the already_configured behaviour.

    ..

    > + if (cdns_phy->already_configured) {
    > + /* Give 5ms to 10ms delay for the PIPE clock to be stable */
    > + usleep_range(5000, 10000);

    fsleep() ?
    (Yes, I see this is the original code, perhaps later in a separate change)

    > + return 0;
    > + }

    --
    With Best Regards,
    Andy Shevchenko



    \
     
     \ /
      Last update: 2024-05-27 15:05    [W:5.917 / U:0.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site