lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v3 02/18] pinctrl: pinctrl-single: remove dead code in suspend() and resume() callbacks
    No need to check the pointer returned by platform_get_drvdata(), as
    platform_set_drvdata() is called during the probe.

    Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
    ---
    drivers/pinctrl/pinctrl-single.c | 12 ++----------
    1 file changed, 2 insertions(+), 10 deletions(-)

    diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
    index 19cc0db771a5..02eabd28d46e 100644
    --- a/drivers/pinctrl/pinctrl-single.c
    +++ b/drivers/pinctrl/pinctrl-single.c
    @@ -1693,11 +1693,7 @@ static void pcs_restore_context(struct pcs_device *pcs)
    static int pinctrl_single_suspend(struct platform_device *pdev,
    pm_message_t state)
    {
    - struct pcs_device *pcs;
    -
    - pcs = platform_get_drvdata(pdev);
    - if (!pcs)
    - return -EINVAL;
    + struct pcs_device *pcs = platform_get_drvdata(pdev);

    if (pcs->flags & PCS_CONTEXT_LOSS_OFF) {
    int ret;
    @@ -1712,11 +1708,7 @@ static int pinctrl_single_suspend(struct platform_device *pdev,

    static int pinctrl_single_resume(struct platform_device *pdev)
    {
    - struct pcs_device *pcs;
    -
    - pcs = platform_get_drvdata(pdev);
    - if (!pcs)
    - return -EINVAL;
    + struct pcs_device *pcs = platform_get_drvdata(pdev);

    if (pcs->flags & PCS_CONTEXT_LOSS_OFF)
    pcs_restore_context(pcs);
    --
    2.39.2


    \
     
     \ /
      Last update: 2024-05-27 15:05    [W:2.228 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site