Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Thu, 15 Feb 2024 12:05:37 +0100 | Subject | Re: [PATCH v2 00/15] auxdisplay: linedisp: Clean up and add new driver |
| |
Hi Andy,
On Wed, Feb 14, 2024 at 7:45 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > On Wed, Feb 14, 2024 at 6:57 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Feb 12, 2024 at 07:01:33PM +0200, Andy Shevchenko wrote: > > > Add a new initial driver for Maxim MAX6958/6959 chips. > > > While developing that driver I realised that there is a lot > > > of duplication between ht16k33 and a new one. Hence set of > > > cleanups and refactorings. > > > > > > Note, the new driver has minimum support of the hardware and > > > I have plans to cover more features in the future. > > > > > > In v2: > > > - updated DT bindings to follow specifications and requirements (Krzysztof) > > > - unified return code variable (err everywhere) > > > - left patches 10 and 13 untouched, we may amend later on (Robin) > > > > Geert, I would like to apply at least the first 13 patches. > > Do you have any comments or even possibility to perform a regression test? > > I'll try to give it a try on my Adafruit Quad 14-segment display tomorrow..
With the missing return-statement added, the ht16k33 driver builds and works fine: the kernel version is happily scrolling by. I didn't test userspace line display control, as there is an issue with the uSD interface on my OrangeCrab, preventing it from booting into userspace.
Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |