Messages in this thread Patch in this message | | | Date | Thu, 15 Feb 2024 11:40:43 +0100 | Subject | Re: [PATCH 3/9] soc: mediatek: cmdq: Add cmdq_pkt_eoc() helper function | From | AngeloGioacchino Del Regno <> |
| |
Il 15/02/24 01:49, Chun-Kuang Hu ha scritto: > cmdq_pkt_eoc() append eoc command to CMDQ packet. eoc command > would ask GCE to generate IRQ. It's usually appended to the end > of packet to notify all command in the packet is done. > > Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 10 ++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 15 +++++++++++++++ > 2 files changed, 25 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index ed4ef95adf5b..e982997117c2 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -359,6 +359,16 @@ int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_pa) > } > EXPORT_SYMBOL(cmdq_pkt_jump); > > +int cmdq_pkt_eoc(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction inst = { {0} }; > + > + inst.op = CMDQ_CODE_EOC; > + inst.value = CMDQ_EOC_IRQ_EN; > + return cmdq_pkt_append_command(pkt, inst); > +} > +EXPORT_SYMBOL(cmdq_pkt_eoc); > + > int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > struct cmdq_instruction inst = { {0} }; > diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h > index 6215191a328d..a67f719dec0b 100644 > --- a/include/linux/soc/mediatek/mtk-cmdq.h > +++ b/include/linux/soc/mediatek/mtk-cmdq.h > @@ -245,6 +245,16 @@ int cmdq_pkt_assign(struct cmdq_pkt *pkt, u16 reg_idx, u32 value); > */ > int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_pa); > > +/** > + * cmdq_pkt_eoc() - Append eoc command to the CMDQ packet, ask GCE > + * to generate IRQ. It's usually appended to the end of > + * packet to notify that all command in the packet is done. > + * @pkt: the CMDQ packet > + * > + * Return: 0 for success; else the error code is returned
/** * cmdq_pkt_eoc() - Append EOC and ask GCE to generate an IRQ at end of execution * @pkt: The CMDQ packet * * Appends an End Of Code (EOC) command to the CMDQ packet and asks the GCE * to generate an interrupt at the end of the execution of all commands in * the pipeline. * The EOC command is usually appended to the end of the pipeline to notify * that all commands are done. * * Return: 0 for success or negative error number */
Apart from that,
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> + */ > +int cmdq_pkt_eoc(struct cmdq_pkt *pkt); > + > /** > * cmdq_pkt_finalize() - Append EOC and jump command to pkt. > * @pkt: the CMDQ packet > @@ -346,6 +356,11 @@ static inline int cmdq_pkt_jump(struct cmdq_pkt *pkt, dma_addr_t addr, u8 shift_ > return -EINVAL; > } > > +static inline int cmdq_pkt_eoc(struct cmdq_pkt *pkt) > +{ > + return -EINVAL; > +} > + > static inline int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > { > return -EINVAL;
| |