Messages in this thread | | | From | Paul Moore <> | Date | Thu, 15 Feb 2024 22:54:49 -0500 | Subject | Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache_create |
| |
On Tue, Jan 30, 2024 at 4:40 AM Kunwu Chan <chentao@kylinos.cn> wrote: > > commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation") > introduces a new macro. > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > to simplify the creation of SLAB caches. > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn> > --- > kernel/cred.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
This seems reasonable to me, unless I see any objections I can pull this via the LSM tree next week.
> diff --git a/kernel/cred.c b/kernel/cred.c > index c033a201c808..02a96e9d9cfd 100644 > --- a/kernel/cred.c > +++ b/kernel/cred.c > @@ -606,8 +606,8 @@ int set_cred_ucounts(struct cred *new) > void __init cred_init(void) > { > /* allocate a slab in which we can store credentials */ > - cred_jar = kmem_cache_create("cred_jar", sizeof(struct cred), 0, > - SLAB_HWCACHE_ALIGN|SLAB_PANIC|SLAB_ACCOUNT, NULL); > + cred_jar = KMEM_CACHE(cred, > + SLAB_HWCACHE_ALIGN | SLAB_PANIC | SLAB_ACCOUNT); > } > > /** > -- > 2.39.2
-- paul-moore.com
| |