lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v7 00/13] Introduce PHY listing and link_topology tracking
Hi Jakub,

On Wed, 14 Feb 2024 16:59:02 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Tue, 13 Feb 2024 16:04:17 +0100 Maxime Chevallier wrote:
> > This is V7 for the link topology addition, allowing to track all PHYs
> > that are linked to netdevices.
> >
> > The main change in V7 is the protection of the main internal API
> > entrypoints (link_topo_init/cleanup, link_topo_add/del_phy) by
> > IS_REACHABLE(CONFIG_PHYLIB).
> >
> > That's restrictive, but it looks difficult to do otherwise while still keep the
> > data structure opaque and not add dependency clutter with PHYLIB.
> >
> > As you can tell, I'm unsure about this, so please don't hesitate to
> > comment on that part :)
> >
> > The other changes are very minor, the only one is a call to netdev_put
> > in the .done() netlink callback.
> >
> > As a remainder, here's what the PHY listings would look like :
> > - eth0 has a 88x3310 acting as media converter, and an SFP module with
> > an embedded 88e1111 PHY
> > - eth2 has a 88e1510 PHY
>
> Needs a rebase, core has been busy lately:

Arg, I'll send a rebased version, sorry about that

Best regards,

Maxime

\
 
 \ /
  Last update: 2024-05-27 15:04    [W:0.643 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site