Messages in this thread Patch in this message | | | Date | Thu, 15 Feb 2024 12:54:59 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 00/30] PREEMPT_AUTO: support lazy rescheduling |
| |
On Thu, Feb 15, 2024 at 09:04:00PM +0100, Thomas Gleixner wrote: > On Thu, Feb 15 2024 at 11:28, Paul E. McKenney wrote: > > On Wed, Feb 14, 2024 at 07:45:18PM -0800, Paul E. McKenney wrote: > > I am also getting these from builds that enable KASAN: > > > > vmlinux.o: warning: objtool: mwait_idle+0x13: call to tif_resched.constprop.0() leaves .noinstr.text section > > vmlinux.o: warning: objtool: acpi_processor_ffh_cstate_enter+0x36: call to tif_resched.constprop.0() leaves .noinstr.text section > > vmlinux.o: warning: objtool: cpu_idle_poll.isra.0+0x18: call to tif_resched.constprop.0() leaves .noinstr.text section > > vmlinux.o: warning: objtool: acpi_safe_halt+0x0: call to tif_resched.constprop.0() leaves .noinstr.text section > > vmlinux.o: warning: objtool: poll_idle+0x33: call to tif_resched.constprop.0() leaves .noinstr.text section > > vmlinux.o: warning: objtool: default_enter_idle+0x18: call to tif_resched.constprop.0() leaves .noinstr.text section > > > > Does tif_resched() need to be marked noinstr or some such? > > __always_inline() probably
That does the trick, thank you!
Thanx, Paul
------------------------------------------------------------------------
diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h index 8752dbc2dac75..43b729935804e 100644 --- a/include/linux/thread_info.h +++ b/include/linux/thread_info.h @@ -81,7 +81,7 @@ typedef enum { * reduce to the same value (TIF_NEED_RESCHED) leaving any scheduling behaviour * unchanged. */ -static inline int tif_resched(resched_t rs) +static __always_inline int tif_resched(resched_t rs) { return TIF_NEED_RESCHED + rs * TIF_NEED_RESCHED_LAZY_OFFSET; }
| |