lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v8 2/2] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests
    Date
    ...
    > > Descriptors need 8-byte alignment for efficiency on 64-bit parisc. The pc and gp are accessed
    > > using ldd instructions.
    > >
    >
    > How about the patch below ?

    I think you still need something to avoid the misalignment trap
    in the 'false' case.

    If they only need to be aligned 'for efficiency' then I'd assume
    the cpu (or whatever normally processes them) is ok with 4-byte
    alignment even though 'ldd' (8 byte load?) faults.

    Which would mean you need to read them with two 4-byte loads.

    Especially if 'fn' isn't just one of a couple of specific values
    that can be forced to be aligned.

    But the code might just be completely broken.
    (as suggested elsewhere).

    David

    -
    Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
    Registration No: 1397386 (Wales)
    \
     
     \ /
      Last update: 2024-05-27 15:05    [W:4.166 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site