Messages in this thread | | | From | Max Kellermann <> | Date | Thu, 15 Feb 2024 20:35:58 +0100 | Subject | Re: [PATCH v1 06/14] linux/mm.h: move page_size() to mm/page_size.h |
| |
On Thu, Feb 15, 2024 at 8:26 PM Matthew Wilcox <willy@infradead.org> wrote: > We're really close to eliminating page_size(). Just 23 callers left. > As such, it would be a mistake to name the header after it. I don't > particularly like how you're splitting up mm.h; I think the real problem > is all the code that says "Oh, I'm allocating memory, I should include > mm.h" instead of including gfp.h or slab.h.
Yes, a lot of source files do that, but that mistake is not something I'm addressing in this patch series; another patch series I posted two weeks ago is about that. This series is only about making sources lighter which currently indeed need mm.h.
> But if you must split it like this, at least call it folio_size.h
Okay, I will rename it for v2.
| |