Messages in this thread | | | Date | Thu, 15 Feb 2024 18:32:06 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: sfp: remove redundant NULL check |
| |
> However, I'll go back to my original point: this is *not* something > that automated tools should be identifying, and it is *not* something > that should be used to throw patches randomly out, especially where > the commit message doesn't include human analysis details.
Hi Daniil
Could you work on SVACE and make it dump how it decided it was safe to remove the NULL check. I assume it found the path via sfp_register_socket(), and the NULL check in that. So it should be able to dump that info in some form. sfp_bus_add_upstream() seems more interesting and it would be interesting to know why it though a NULL from there was impossible.
It would be great if the tool dumped some text which could be cut/paste into the commit message as a justification for the change.
Andrew
| |