lkml.org 
[lkml]   [2024]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net v3] net: ravb: Count packets instead of descriptors in GbEth RX path
From
On 15/02/2024 16:03, Jakub Kicinski wrote:
> On Wed, 14 Feb 2024 15:12:04 +0000 Paul Barker wrote:
>> The units of "work done" in the RX path should be packets instead of
>> descriptors, as large packets can be spread over multiple descriptors.
>
> FWIW one of y'all may also want to look into processing Tx completions
> before Rx. Tx completions can free memory which Rx can then consume.
> More efficient. Not to mention netconsole being able to reap Tx with
> budget of 0.

Thanks for the recommendation - I'll make this change as part of v3 of
the series "Improve GbEth performance on Renesas RZ/G2L and related
SoCs" [1] once we've completed gPTP testing.

[1]: https://lore.kernel.org/netdev/20240206091909.3191-1-paul.barker.ct@bp.renesas.com/

--
Paul Barker[unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 15:05    [W:0.417 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site