Messages in this thread | | | Date | Mon, 12 Feb 2024 14:56:43 +0100 | Subject | Re: [PATCH 1/3] dt-bindings: auxdisplay: hit,hd44780: drop redundant GPIO node | From | Krzysztof Kozlowski <> |
| |
On 12/02/2024 14:39, Andy Shevchenko wrote: > On Mon, Feb 12, 2024 at 09:34:24AM +0100, Krzysztof Kozlowski wrote: >> Examples of other nodes, like GPIO controller, are redundant and not >> really needed in device bindings. > > ... > >> - i2c { >> - #address-cells = <1>; >> - #size-cells = <0>; >> >> - pcf8574: pcf8574@27 { >> - compatible = "nxp,pcf8574"; >> - reg = <0x27>; >> - gpio-controller; >> - #gpio-cells = <2>; >> - }; >> - }; > > In patch 3 you updated the lines that have lost their sense due to this one.
How did they lose it?
> And I agree with others, please leave this example in place.
What for? Why this binding is special and 99% of others do not need GPIO expander in the example?
Best regards, Krzysztof
| |