Messages in this thread | | | Date | Mon, 12 Feb 2024 08:32:46 -0300 | From | "Ricardo B. Marliere" <> | Subject | Re: [PATCH] dio: make dio_bus_type const |
| |
On 12 Feb 11:44, Greg Kroah-Hartman wrote: > On Sun, Feb 11, 2024 at 12:40:16PM -0300, Ricardo B. Marliere wrote: > > Now that the driver core can properly handle constant struct bus_type, > > move the dio_bus_type variable to be a constant structure as well, > > placing it into read-only memory which can not be modified at runtime. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> > > --- > > drivers/dio/dio-driver.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/dio/dio-driver.c b/drivers/dio/dio-driver.c > > index 69c46935ffc7..2d9fa6011945 100644 > > --- a/drivers/dio/dio-driver.c > > +++ b/drivers/dio/dio-driver.c > > @@ -123,7 +123,7 @@ static int dio_bus_match(struct device *dev, struct device_driver *drv) > > } > > > > > > -struct bus_type dio_bus_type = { > > +const struct bus_type dio_bus_type = { > > .name = "dio", > > .match = dio_bus_match, > > .probe = dio_device_probe, > > > > Don't you also have to change this in include/linux/dio.h?
Indeed, I missed it. Will send a v2, thank you.
> > thanks, > > greg k-h
| |