Messages in this thread | | | Date | Mon, 12 Feb 2024 12:08:43 +0100 | Subject | Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-pmics: Define adc for temp-alarms | From | Konrad Dybcio <> |
| |
On 11.02.2024 05:42, Bjorn Andersson via B4 Relay wrote: > From: Bjorn Andersson <quic_bjorande@quicinc.com> > > sc8280xp-pmics define the two thermal zones "pm8280-1-thermal" and > "pm8280-2-thermal", but the related temp-alarm instances are not tied to > any adc channels, and as such continuously report the bogus temperature > of 37C. > > After previously defining these adc channels across all boards using > sc8280xp-pmics.dtsi, we can now add these references. > > This does however mean that we have a non-disabled node referencing > default-disabled nodes, requiring each board to enable the pmk8280_vadc. > Avoid this by marking pmk8280_vadc okay.
Thanks for addressing my P1 review comments in a way that indicates time travel has been achieved ;)
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
| |