Messages in this thread | | | From | Subbaraman Narayanamurthy <> | Subject | Re: [PATCH v3] soc: qcom: rpmh-rsc: Enhance check for VRM in-flight request | Date | Mon, 12 Feb 2024 19:52:03 -0800 |
| |
Hi Maulik,
> +bool cmd_db_match_resource_addr(u32 addr1, u32 addr2) > +{
<snip>
> + if (SLAVE_ID(addr1) == CMD_DB_HW_VRM > + && VRM_ADDR(addr1) == VRM_ADDR(addr2)) > + return true; > + else if (addr1 == addr2) > + return true; > + else > + return false;
Minor..it would be better if you modify it as following.
+ if (addr1 == addr2) + return true; + else if (SLAVE_ID(addr1) == CMD_DB_HW_VRM + && VRM_ADDR(addr1) == VRM_ADDR(addr2)) + return true; + + return false;
-Subbaraman
-- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |