lkml.org 
[lkml]   [2024]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] drm/crtc: fix uninitialized variable use even harder
    From


    On 2/12/2024 1:55 PM, Rob Clark wrote:
    > From: Rob Clark <robdclark@chromium.org>
    >
    > DRM_MODESET_LOCK_ALL_BEGIN() has a hidden trap-door (aka retry loop),
    > which means we can't rely too much on variable initializers.
    >
    > Fixes: 6e455f5dcdd1 ("drm/crtc: fix uninitialized variable use")
    > Signed-off-by: Rob Clark <robdclark@chromium.org>
    > ---
    > I have mixed feelings about DRM_MODESET_LOCK_ALL_BEGIN() (and friends)
    > magic. On one hand it simplifies the deadlock/back dance. OTOH it
    > conceals a nasty sharp edge. Maybe it is better to have the complicated
    > restart path a bit more explicit, like it was originally.
    >
    > drivers/gpu/drm/drm_crtc.c | 1 +
    > 1 file changed, 1 insertion(+)
    >

    Nice catch !!

    Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

    \
     
     \ /
      Last update: 2024-05-27 15:00    [W:7.440 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site