lkml.org 
[lkml]   [2024]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH net-next v2 6/7] net: ravb: Enable SW IRQ Coalescing for GbEth
From
Date
On 2/12/24 2:45 PM, Paul Barker wrote:
[...]
>>> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
>>> index 55a7a08aabef..ca7a66759e35 100644
>>> --- a/drivers/net/ethernet/renesas/ravb.h
>>> +++ b/drivers/net/ethernet/renesas/ravb.h
>>> @@ -1078,6 +1078,7 @@ struct ravb_hw_info {
>>> unsigned nc_queues:1; /* AVB-DMAC has RX and TX NC queues */
>>> unsigned magic_pkt:1; /* E-MAC supports magic packet detection */
>>> unsigned half_duplex:1; /* E-MAC supports half duplex mode */
>>> + unsigned needs_irq_coalesce:1; /* Requires SW IRQ Coalescing to achieve best performance */
>>
>> Is this really a hardware feature?
>
> It's more like a requirement to get the best out of this hardware and the Linux networking stack.
>
> I considered checking the compatible string in the probe function but I decided that storing a configuration bit in the HW info struct was cleaner.

Yes, but you added the new bit under the "hardware features" commet. :-)

>> Also, s/Requires SW/Needs software/ and s/to achieve best performance//,
>> please...
>
> Will do.

The comment is too long, I think. :-)

[...]

> Thanks for the review,
> Paul

MBR, Sergey

\
 
 \ /
  Last update: 2024-05-27 14:59    [W:0.271 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site