lkml.org 
[lkml]   [2024]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/2] x86/MCE: Add command line option to extend MCE Records pool
From
On 2/12/2024 1:58 PM, Luck, Tony wrote:
>> I need to look more at the genpool code, but I thought I'd ask too.
>
> Yazen,
>
> gen_pool_add_owner() is the code that adds an extra chunk to an existing genpool.
>
> This bit doesn't look obviously safe against a #MC at the wrong moment in the middle of
> the list_add_rcu()
>
> spin_lock(&pool->lock);
> list_add_rcu(&chunk->next_chunk, &pool->chunks);
> spin_unlock(&pool->lock);
>

Thanks Tony.

So the concern is not about traversal, but rather that the #MC can break the
list_add_rcu(). Is this correct?


Thanks,
Yazen

\
 
 \ /
  Last update: 2024-05-27 14:59    [W:0.100 / U:1.932 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site