Messages in this thread | | | Date | Mon, 12 Feb 2024 13:29:30 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 1/2] ACPI: use %pe for better readability of errors while printing |
| |
On Mon, Feb 12, 2024 at 03:54:03PM +0530, Onkarnarth wrote: > From: Onkarnath <onkarnath.1@samsung.com> > > As %pe is already introduced, it's better to use it in place of (%ld) for > printing errors in logs. It would enhance readability of logs. > > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> > Signed-off-by: Onkarnath <onkarnath.1@samsung.com> > Reviewed-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > Reviewed-by: Bjorn Helgaas <helgaas@kernel.org>
This tag is wrong. I provided some feedback, but that's not the same as providing a "Reviewed-by" tag. "Reviewed-by" has a very specific meaning and the reviewer must provide it explicitly; details here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=v6.7#n544
Bjorn
| |