Messages in this thread | | | Date | Mon, 12 Feb 2024 10:39:55 -0800 | From | Kees Cook <> | Subject | Re: [PATCH] configs/debug: add NET debug config |
| |
On Mon, Feb 12, 2024 at 11:47:14AM +0100, Matthieu Baerts (NGI0) wrote: > The debug.config file is really great to easily enable a bunch of > general debugging features on a CI-like setup. But it would be great to > also include core networking debugging config. > > A few CI's validating features from the Net tree also enable a few other > debugging options on top of debug.config. A small selection is quite > generic for the whole net tree. They validate some assumptions in > different parts of the core net tree. As suggested by Jakub Kicinski in > [1], having them added to this debug.config file would help other CIs > using network features to find bugs in this area. > > Note that the two REFCNT configs also select REF_TRACKER, which doesn't > seem to be an issue. > > Link: https://lore.kernel.org/netdev/20240202093148.33bd2b14@kernel.org/T/ [1] > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> > --- > Notes: > - It looks like this debug.config doesn't have a specific maintainer. > If this patch is not rejected, I don't know if this modification can > go through the net tree, or if it should be handled by Andrew. > Probably the latter? I didn't add [net-next] in the subject for this > reason.
Adding these seem reasonable. I touched debug.config last, so I can take it via the kernel hardening tree if netdev doesn't want to take it.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > kernel/configs/debug.config | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/kernel/configs/debug.config b/kernel/configs/debug.config > index 4722b998a324..509ee703de15 100644 > --- a/kernel/configs/debug.config > +++ b/kernel/configs/debug.config > @@ -40,6 +40,12 @@ CONFIG_UBSAN_ENUM=y > CONFIG_UBSAN_SHIFT=y > CONFIG_UBSAN_UNREACHABLE=y > # > +# Networking Debugging > +# > +CONFIG_NET_DEV_REFCNT_TRACKER=y > +CONFIG_NET_NS_REFCNT_TRACKER=y > +CONFIG_DEBUG_NET=y > +# > # Memory Debugging > # > # CONFIG_DEBUG_PAGEALLOC is not set > > --- > base-commit: 841c35169323cd833294798e58b9bf63fa4fa1de > change-id: 20240212-kconfig-debug-enable-net-c2dc61002252 > > Best regards, > -- > Matthieu Baerts (NGI0) <matttbe@kernel.org> >
-- Kees Cook
| |