lkml.org 
[lkml]   [2024]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] serial: core: introduce uart_port_tx_flags()
From
On 31. 01. 24, 13:13, Jiri Slaby (SUSE) wrote:
> And an enum with a flag: UART_TX_NOSTOP. To NOT call
> __port->ops->stop_tx() when the circular buffer is empty. mxs-uart needs
> this (see the next patch).
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Emil Kronborg <emil.kronborg@protonmail.com>
> ---
> include/linux/serial_core.h | 32 +++++++++++++++++++++++++++-----
> 1 file changed, 27 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
> index 536b2581d3e2..edefb6d73604 100644
> --- a/include/linux/serial_core.h
> +++ b/include/linux/serial_core.h
> @@ -748,8 +748,17 @@ struct uart_driver {
>
> void uart_write_wakeup(struct uart_port *port);
>
> -#define __uart_port_tx(uport, ch, tx_ready, put_char, tx_done, for_test, \
> - for_post) \
> +/**
> + * enum UART_TX_FLAGS -- flags for uart_port_tx_flags()
> + *
> + * @UART_TX_NOSTOP: don't call port->ops->stop_tx() on empty buffer
> + */
> +enum UART_TX_FLAGS {
> + UART_TX_NOSTOP = BIT(0),
> +};
> +
> +#define __uart_port_tx(uport, ch, flags, tx_ready, put_char, tx_done, \
> + for_test, for_post) \
> ({ \
> struct uart_port *__port = (uport); \
> struct circ_buf *xmit = &__port->state->xmit; \
> @@ -777,7 +786,7 @@ void uart_write_wakeup(struct uart_port *port);
> if (pending < WAKEUP_CHARS) { \
> uart_write_wakeup(__port); \
> \
> - if (pending == 0) \
> + if (((flags) & UART_TX_NOSTOP) && pending == 0) \

Hold on, this is obviously inverted!

--
js
suse labs


\
 
 \ /
  Last update: 2024-05-27 14:41    [W:0.030 / U:3.872 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site