Messages in this thread | | | Date | Wed, 31 Jan 2024 18:13:56 +0800 | Subject | Re: [PATCH v2] dt-bingdings: perf: Support uncore ARM NI-700 PMU | From | Yang Jialong 杨佳龙 <> |
| |
在 2024/1/31 17:30, Krzysztof Kozlowski 写道: > On 31/01/2024 10:26, Yang Jialong 杨佳龙 wrote: >> >> >> 在 2024/1/31 15:49, Krzysztof Kozlowski 写道: >>> On 31/01/2024 07:59, JiaLong.Yang wrote: >>>> Add file corresponding to hx_arm_ni.c introducing ARM NI-700 PMU driver >>>> for HX. >>>> >>>> Signed-off-by: JiaLong.Yang <jialong.yang@shingroup.cn> >>>> --- >>>> v1 --> v2: >>>> 1. Submit dt-bindings file Seperately. >>> >>> Where is the driver? >>> >>> Please read: >>> https://elixir.bootlin.com/linux/v6.8-rc2/source/Documentation/process/submitting-patches.rst >>> before posting. >>> > > Keep all discussions public.
Get.
> > >>>> + pccs-id: >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>>> + description: Used to identify NIs in system which has more than >>>> + one NI. >>> >>> No, reg does it. Drop the property. Anyway you miss here vendor prefix >>> and proper explanation. >>> >> >> reg will tell phy address. Phy address is too long. I just want a id. >> example: perf stat -a -e ni_pmu_${pccs-id}/cycles/ >> I will use it in user space. Not only in driver. > > Custom vendor property is not for that purpose. Use for example IDR, DT > aliases or something else. > >
I have considered TD aliases. It's not very easy. Two places... IDR.. I have tested. But it chouldn't correspond to the HWs. I need it to identify NIs. DT aliases is reachable. But no very easy.
>>> > > Best regards, > Krzysztof > >
| |