Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2 1/5] media: i2c: imx335: Drop setting of 0x3a00 register | From | Kieran Bingham <> | Date | Wed, 31 Jan 2024 09:52:54 +0000 |
| |
Hi Umang,
+ Cc: Matthias
Quoting Umang Jain (2024-01-31 05:52:04) > Register 0x3a00 is a reserved field as per the IMX335 datasheet, > hence shouldn't be set by the driver.
We still need to explain more about why we're dropping this register write, and what effects it causes.
Matthias - I believe this stemmed from the work you did, and I think I recall that you stated this register write broke the CSI2 configuration?
Can you clarify anything here for us please?
-- Kieran
> > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/media/i2c/imx335.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c > index 7a37eb327ff4..927b4806a5d7 100644 > --- a/drivers/media/i2c/imx335.c > +++ b/drivers/media/i2c/imx335.c > @@ -249,7 +249,6 @@ static const struct imx335_reg mode_2592x1940_regs[] = { > {0x3794, 0x7a}, > {0x3796, 0xa1}, > {0x37b0, 0x36}, > - {0x3a00, 0x01}, > }; > > static const struct imx335_reg raw10_framefmt_regs[] = { > -- > 2.41.0 >
| ![\](/images/icornerr.gif) |