Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 31 Jan 2024 20:36:46 -0500 | From | Aren <> | Subject | Re: [PATCH 2/4] arm64: dts: sun50i-a64-pinephone: Retain leds state in suspend |
| |
On Tue, Jan 30, 2024 at 08:06:24PM +0100, Jernej Škrabec wrote: > Dne nedelja, 28. januar 2024 ob 21:45:08 CET je Aren Moynihan napisal(a): > > From: Miles Alan <m@milesalan.com> > > > > Allows user to set a led before entering suspend to know that > > the phone is still on (or could be used for notifications etc.) > > > > Signed-off-by: Miles Alan <m@milesalan.com> > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > > Signed-off-by: Aren Moynihan <aren@peacevolution.org> > > Where is patch 1 and possibly cover letter? Please resend with all patches.
Oops, sorry about that, I'm still getting used to get_maintainer.pl. I'll resend this properly when I have time this weekend, until then the patch you missed is available at https://lore.kernel.org/lkml/20240128204740.2355092-1-aren@peacevolution.org/
> However, this particular patch is: > Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Thanks - Aren
> Best regards, > Jernej > > > --- > > > > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > index 87847116ab6d..ad2476ee01e4 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi > > @@ -43,18 +43,21 @@ led-0 { > > function = LED_FUNCTION_INDICATOR; > > color = <LED_COLOR_ID_BLUE>; > > gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */ > > + retain-state-suspended; > > }; > > > > led-1 { > > function = LED_FUNCTION_INDICATOR; > > color = <LED_COLOR_ID_GREEN>; > > gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */ > > + retain-state-suspended; > > }; > > > > led-2 { > > function = LED_FUNCTION_INDICATOR; > > color = <LED_COLOR_ID_RED>; > > gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */ > > + retain-state-suspended; > > }; > > }; > > > > > > > >
| ![\](/images/icornerr.gif) |