lkml.org 
[lkml]   [2024]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] dt-bindings: net: Add TI DP83640
On Wed, Jan 31, 2024 at 03:05:21PM -0600, Rob Herring wrote:
> On Tue, Jan 30, 2024 at 05:56:37PM +0000, Conor Dooley wrote:
> > On Tue, Jan 30, 2024 at 09:59:34AM +0100, Bastien Curutchet wrote:

> > > + ti,fiber-mode:
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + enum: [0, 1]
> > > + description: |
> > > + If present, enables or disables the FX Fiber Mode.
> > > + Fiber mode support can also be strapped. If the strap pin is not set
> > > + correctly or not set at all then this can be used to configure it.
> > > + - 0 = FX Fiber Mode disabled
> > > + - 1 = FX Fiber Mode enabled
> > > + - unset = Configured by straps
> >
> > I don't like these properties that map meanings onto numbers. We can
> > have enums of strings in bindings that allow you to use something more
> > meaningful than "0" or "1".
>
> Tristate properties are fairly common pattern where we need
> on/off/default. I've thought about making it a type. I don't think we
> need defines for it.

I think a type would be a good idea. I am not at all a fan of any of the
properties people introduce along these lines.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2024-05-27 14:43    [W:0.103 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site