Messages in this thread | | | Date | Wed, 31 Jan 2024 23:40:01 +0530 | Subject | Re: [PATCH v2] usb: gadget: ncm: Avoid dropping datagrams of properly parsed NTBs | From | Krishna Kurapati PSSNV <> |
| |
On 1/31/2024 10:48 PM, Maciej Żenczykowski wrote:
>> >> Also since this is a fix, it should probably have a Fixes tag >> (possibly on some original sha1 that added the driver, since I think >> it's always been broken) or at least a commit title that more clearly >> flags it as a 'fix' or cc stable... >> >> (something like 'usb: gadget: ncm: fix rare win11 packet discard') >> >> We definitely want this to hit LTS... > > One more thing: the 'goto done' and 'done' label are not needed - > that's already the natural code flow... > So the 'goto' could just be replaced with a comment or perhaps with > --to_process.
ACK. I thought getting out of the function was better than doing a NOP calculation. Either ways is fine by me. Will make this change in v3.
Regards, Krishna,
| |