Messages in this thread | | | Date | Wed, 31 Jan 2024 19:01:47 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH v3 1/1] pidfd: implement PIDFD_THREAD flag for pidfd_open() |
| |
On 01/31, Tycho Andersen wrote: > > > int pidfd_prepare(struct pid *pid, unsigned int flags, struct file **ret) > > { > > - if (!pid || !pid_has_task(pid, PIDTYPE_TGID)) > > + bool thread = flags & PIDFD_THREAD; > > + > > + if (!pid || !pid_has_task(pid, thread ? PIDTYPE_PID : PIDTYPE_TGID)); > > Small typo here, trailing ;. When I fix that, tests pass for me.
OOPS.
Christian, should I spam lkml with v4, or will you add this fix yourself?
> Assuming that's fixed up: > > Reviewed-by: Tycho Andersen <tandersen@netflix.com> > Tested-by: Tycho Andersen <tandersen@netflix.com>
Thanks Tycho!!!
Oleg.
| |