Messages in this thread | | | Date | Fri, 12 Jan 2024 15:54:06 -0600 | Subject | Re: [PATCH v4 2/2] x86/resctrl: Read supported bandwidth sources using CPUID command | From | "Moger, Babu" <> |
| |
Hi Reinette,
On 1/12/2024 3:24 PM, Reinette Chatre wrote: > Hi Babu, > > On 1/12/2024 12:38 PM, Moger, Babu wrote: >> Hi Reinette, >> >> On 1/12/2024 1:02 PM, Reinette Chatre wrote: >>> Hi Babu, >>> >>> On 1/11/2024 1:36 PM, Babu Moger wrote: >>> >>>> @@ -1686,6 +1681,13 @@ static int mon_config_write(struct rdt_resource *r, char *tok, u32 evtid) >>>> return -EINVAL; >>>> } >>>> + /* mon_config cannot be more than the supported set of events */ >>> copy&paste error? There is no mon_config in this function. >> Yea. it should be mbm_cfg_mask. Will fix it. > I do not think it is correct to replace mon_config with mbm_cfg_mask. Is this comment > not referring to the user provided value (that is checked against mbm_cfg_mask)? So > perhaps something like: > > /* Check value from user against supported events. */ > or > /* Value from user cannot be more than the supported set of events. */
This looks good. Thanks
Babu
| |