lkml.org 
[lkml]   [2024]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/7] hugetlb: split hugetlb_hstate_alloc_pages
From
On 2024/1/11 07:12, Tim Chen wrote:
> On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote:
>> +static unsigned long __init hugetlb_hstate_alloc_pages_gigantic(struct hstate *h)
>> +{
>> + unsigned long i;
>> +
>> + for (i = 0; i < h->max_huge_pages; ++i) {
>> + /*
>> + * gigantic pages not added to list as they are not
>> + * added to pools now.
>> + */
>
> This comment unnecessary as now we don't have mix gigantic and non-gigantic code,
> which uses foilio list. And folio_list is not in this routine.
>
> Can be removed.
>
> Otherwise Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com>
>

Thanks!

\
 
 \ /
  Last update: 2024-01-11 04:45    [W:0.061 / U:3.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site