lkml.org 
[lkml]   [2024]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Drivers: hv: vmbus: One function call less in create_gpadl_header() after error detection
Date
From: Dan Carpenter <dan.carpenter@linaro.org> Sent: Wednesday, January 10, 2024 11:05 PM
>
> On Wed, Jan 10, 2024 at 10:17:17PM +0000, Michael Kelley wrote:
> > From: Dan Carpenter <dan.carpenter@linaro.org> Sent: Wednesday, January
> 10, 2024 10:38 AM
> > >
> > > The second half of the if statement is basically duplicated. It doesn't
> > > need to be treated as a special case. We could do something like below.
> > > I deliberately didn't delete the tabs. Also I haven't tested it.
> >
> > Indeed! I looked at the history, and this function has been
> > structured with the duplication since sometime in 2010, which
> > pre-dates my involvement by several years. I don't know of
> > any reason why the duplication is needed, and agree it could
> > be eliminated.
> >
> > Assuming Markus is OK with my proposal on the handling of
> > memory allocation failures, a single patch could simplify this
> > function quite a bit.
> >
> > Dan -- do you want to create and submit the patch? I'll test the
> > code on Hyper-V. Or I can create, test, and submit the patch with
> > a "Suggested-by: Dan Carpenter".
>
> I messed up the if statement the first couple times I tried to think
> about it so I don't trust myself here. Could you give me the
> Suggested-by tag?
>

Will do.

Michael

\
 
 \ /
  Last update: 2024-01-11 15:50    [W:0.067 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site