lkml.org 
[lkml]   [2024]   [Jan]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe
    On Thu, Jan 11, 2024 at 03:20:18PM +0800, Kunwu Chan wrote:
    > devm_kasprintf() returns a pointer to dynamically allocated memory
    > which can be NULL upon failure.
    >
    > Cc: Kunwu Chan <kunwu.chan@hotmail.com>
    > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
    > Suggested-by: Jakub Kicinski <kuba@kernel.org>

    Hi Kunwu,

    This seems to be a bug fix. If so it should have a fixes tag.
    Perhaps this one is correct?

    Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver")

    And, be targeted against net (as opposed to net-next)

    Subject: [PATCH net v2] ...

    It is probably not necessary to repost to address these minor issues,
    but please keep this in mind in future.

    The above notwithstanding,

    Reviewed-by: Simon Horman <horms@kernel.org>

    \
     
     \ /
      Last update: 2024-01-11 14:51    [W:4.802 / U:1.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site