Messages in this thread | | | From | Ilpo Järvinen <> | Date | Thu, 11 Jan 2024 13:56:28 +0200 (EET) | Subject | Re: [PATCH] platform/x86: silicom-platform: clean up a check |
| |
On Wed, 10 Jan 2024, Dan Carpenter wrote:
> "value" is either non-zero, or zero. There isn't a third option. > Delete the unnecessary code. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- > drivers/platform/x86/silicom-platform.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86/silicom-platform.c > index 6ce43ccb3112..5cac698bf98d 100644 > --- a/drivers/platform/x86/silicom-platform.c > +++ b/drivers/platform/x86/silicom-platform.c > @@ -258,10 +258,8 @@ static void silicom_gpio_set(struct gpio_chip *gc, > > if (value) > silicom_mec_port_set(channel, 0); > - else if (value == 0) > - silicom_mec_port_set(channel, 1); > else > - pr_err("Wrong argument value: %d\n", value); > + silicom_mec_port_set(channel, 1);
This covers both cases without if:
silicom_mec_port_set(channel, !value);
-- i.
| |