Messages in this thread Patch in this message | | | Date | Sat, 9 Sep 2023 19:26:29 +0200 | From | Oleg Nesterov <> | Subject | [PATCH 2/2] getrusage: use __for_each_thread() |
| |
do/while_each_thread should be avoided when possible.
Plus this change allows to avoid lock_task_sighand(), we can use rcu and/or sig->stats_lock instead.
Signed-off-by: Oleg Nesterov <oleg@redhat.com> --- kernel/sys.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/sys.c b/kernel/sys.c index 097cbea62a72..67436d465be4 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1830,10 +1830,8 @@ void getrusage(struct task_struct *p, int who, struct rusage *r) r->ru_oublock += sig->oublock; if (maxrss < sig->maxrss) maxrss = sig->maxrss; - t = p; - do { + __for_each_thread(sig, t) accumulate_thread_rusage(t, r); - } while_each_thread(p, t); break; default: -- 2.25.1.362.g51ebf55
| |