lkml.org 
[lkml]   [2023]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 6.5 6/6] thermal/drivers/sun8i: Free calibration nvmem after reading it
On Fri, Sep 08, 2023 at 09:12:54PM -0400, Sasha Levin wrote:
> From: Mark Brown <broonie@kernel.org>
>
> [ Upstream commit c51592a95f360aabf2b8a5691c550e1749dc41eb ]
>
> The sun8i thermal driver reads calibration data via the nvmem API at
> startup, updating the device configuration and not referencing the data
> again. Rather than explicitly freeing the nvmem data the driver relies
> on devm_ to release it, even though the data is never referenced again.
> The allocation is still tracked so it's not leaked but this is notable
> when looking at the code and is a little wasteful so let's instead
> explicitly free the nvmem after we're done with it.

This is a minor cleanup which as with so much of what's come in today's
backports seems very questionable for stable.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-09-09 14:38    [W:0.068 / U:29.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site