Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sat, 9 Sep 2023 14:12:21 +0200 | Subject | Re: [PATCH 15/52] m68k: emu: Mark version[] __maybe_unused |
| |
Hi Arnd,
On Sat, Sep 9, 2023 at 10:28 AM Arnd Bergmann <arnd@arndb.de> wrote: > On Thu, Sep 7, 2023, at 15:41, Geert Uytterhoeven wrote: > > When building with W=1: > > > > m68k/arch/m68k/emu/nfeth.c:42:19: warning: ‘version’ defined but > > not used [-Wunused-const-variable=] > > 42 | static const char version[] = > > | ^~~~~~~ > > > > Fix this while obeying the wishes of the original copyright holders by > > marking version[] with __maybe_unused. > > > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > That will just drop it from the object file, maybe it should > instead be marked "__used" ?
Given it's been like this since the beginning, I guess it never showed up in the object file anyway...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |