lkml.org 
[lkml]   [2023]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 1/4] PCI: endpoint: Add D-state change notifier support
From

On 8/23/2023 11:49 AM, Manivannan Sadhasivam wrote:
> On Wed, Aug 02, 2023 at 01:14:44PM +0800, kernel test robot wrote:
>> Hi Krishna,
>>
>> kernel test robot noticed the following build warnings:
>>
>> [auto build test WARNING on pci/next]
>> [also build test WARNING on pci/for-linus linus/master v6.5-rc4 next-20230801]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>>
>> url: https://github.com/intel-lab-lkp/linux/commits/Krishna-chaitanya-chundru/PCI-endpoint-Add-D-state-change-notifier-support/20230802-115309
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next
>> patch link: https://lore.kernel.org/r/1690948281-2143-2-git-send-email-quic_krichai%40quicinc.com
>> patch subject: [PATCH v5 1/4] PCI: endpoint: Add D-state change notifier support
>> config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230802/202308021312.obgu7FWM-lkp@intel.com/config)
>> compiler: loongarch64-linux-gcc (GCC) 12.3.0
>> reproduce: (https://download.01.org/0day-ci/archive/20230802/202308021312.obgu7FWM-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202308021312.obgu7FWM-lkp@intel.com/
>>
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/pci/endpoint/pci-epc-core.c:795:6: warning: no previous prototype for 'pci_epc_dstate_notity' [-Wmissing-prototypes]
>> 795 | void pci_epc_dstate_notity(struct pci_epc *epc, pci_power_t state)
> This tells that you haven't build tested the series before sending. Please
> always do both build and functionality testing before sending each iteration.
>
> - Mani

sorry for late reply, till now I was using a different branch which has
some out of tree patches for testing and rebasing the patch on
linux-next to send them because of that few things are getting missed.

Now I took time to completely move to the linux next so that testing and
sending patches will be on same code base.

I will correct this in next patch series.

- KC

>> | ^~~~~~~~~~~~~~~~~~~~~
>>
>>
>> vim +/pci_epc_dstate_notity +795 drivers/pci/endpoint/pci-epc-core.c
>>
>> 785
>> 786 /**
>> 787 * pci_epc_dstate_notity() - Notify the EPF driver that EPC device D-state
>> 788 * has changed
>> 789 * @epc: the EPC device which has change in D-state
>> 790 * @state: the changed D-state
>> 791 *
>> 792 * Invoke to Notify the EPF device that the EPC device has D-state has
>> 793 * changed.
>> 794 */
>> > 795 void pci_epc_dstate_notity(struct pci_epc *epc, pci_power_t state)
>> 796 {
>> 797 struct pci_epf *epf;
>> 798
>> 799 if (!epc || IS_ERR(epc))
>> 800 return;
>> 801
>> 802 mutex_lock(&epc->list_lock);
>> 803 list_for_each_entry(epf, &epc->pci_epf, list) {
>> 804 mutex_lock(&epf->lock);
>> 805 if (epf->event_ops && epf->event_ops->dstate_notify)
>> 806 epf->event_ops->dstate_notify(epf, state);
>> 807 mutex_unlock(&epf->lock);
>> 808 }
>> 809 mutex_unlock(&epc->list_lock);
>> 810 }
>> 811 EXPORT_SYMBOL_GPL(pci_epc_dstate_notity);
>> 812
>>
>> --
>> 0-DAY CI Kernel Test Service
>> https://github.com/intel/lkp-tests/wiki

\
 
 \ /
  Last update: 2023-09-08 06:45    [W:0.275 / U:0.644 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site