Messages in this thread | | | From | Rob Herring <> | Subject | Re: [PATCH] dt-bindings: rtc: mcp795: convert to YAML | Date | Wed, 06 Sep 2023 06:31:59 -0500 |
| |
On Wed, 06 Sep 2023 12:23:10 +0200, Javier Carrasco wrote: > Convert the MCP795 bindings from text to YAML format to support bindings > validation. > > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com> > --- > YAML is the preferred format for dt-bindings, which allows validation. > --- > .../devicetree/bindings/rtc/maxim,mcp795.txt | 11 ------- > .../devicetree/bindings/rtc/maxim,mcp795.yaml | 35 ++++++++++++++++++++++ > 2 files changed, 35 insertions(+), 11 deletions(-) >
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors: Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dts:20.13-23: Warning (reg_format): /example-0/rtc@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/rtc/maxim,mcp795.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230906-topic-rtc_mcp795_yaml-v1-1-de75c377b5b0@gmail.com
The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
| |