Messages in this thread | | | Date | Wed, 6 Sep 2023 12:48:17 +0200 | Subject | Re: [PATCH v2 1/2] dt-bindings: arm64: dts: mediatek: add mt8395-evk board | From | AngeloGioacchino Del Regno <> |
| |
Il 06/09/23 11:53, Macpaul Lin ha scritto: > > > On 9/6/23 17:32, Krzysztof Kozlowski wrote: >> >> >> External email : Please do not click links or open attachments until you have >> verified the sender or the content. >> >> On 06/09/2023 11:25, Macpaul Lin wrote: >>> 1. Add compatible for MT8395. >>> 2. Add bindings for the MediaTek mt8395-evk board, also known >>> as the "Genio 1200-EVK". >>> >>> The MT8195 and MT8395 belong to the same SoC family, >>> with only minor differences in their physical characteristics. >>> They utilize unique efuse values for differentiation. >>> >>> The booting process and configurations are managed by boot >>> loaders, firmware, and TF-A. Consequently, the part numbers >>> and procurement channels vary. >>> >>> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com> >>> --- >>> Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >> >> Do not attach (thread) your patchsets to some other threads (unrelated >> or older versions). This buries them deep in the mailbox and might >> interfere with applying entire sets. >> >>> >>> Changes for v2: >>> - add more detail description for mt8395. >>> - add bindings for mt8395, and mt8395-evk. >>> >>> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml >>> b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> index ae12b1cab9fb..d7a20df640d7 100644 >>> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml >>> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml >>> @@ -248,6 +248,11 @@ properties: >>> - enum: >>> - mediatek,mt8365-evk >>> - const: mediatek,mt8365 >>> + - description: MediaTek Genio 1200 Boards (Genio 1200 EVK) >>> + items: >>> + - enum: >>> + - mediatek,mt8395-evk >>> + - const: mediatek,mt8395 >> >> >> I don't understand. You said last time this is fully compatible with >> mt8195, so why it's not here? >> > > Yes, mt8395 is fully compatible with mt8195. > > But after reading Angelo's comment, we thought it is necessary to create a new > compatible to avoid confusion for users. > https://lore.kernel.org/lkml/bf8394c6-5460-8696-f46b-0c39927aaf84@collabora.com/ > > Although they are fully compatible, developers cannot arbitrarily replace the chip > on the board with another one. So separated bindings might be better.
Sorry you've misunderstood; I was trying to explain to Krzysztof that the two SoCs are fully compatible... my suggestion was in like with what you're trying to do as in I am agreeing with your first version, Macpaul, to inherit MT8195.
So,
- enum - mediatek,mt8395-evk - const: mediatek,mt8195 - const: mediatek,mt8395
> >> Best regards, >> Krzysztof > > Thanks > Macpaul Lin
| |