lkml.org 
[lkml]   [2023]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 08/12] arm64: dts: qcom: msm8998-pro1: correct UFS pad supply
    From
    On 5.09.2023 18:19, Krzysztof Kozlowski wrote:
    > The Qualcomm UFS phy switched from dedicated driver to QMP phy driver.
    > Eventually the old driver was removed in commit 02dca8c981b5 ("phy:
    > qcom: remove ufs qmp phy driver"). The original driver and its binding
    > used vddp-ref-clk regulator supply, but the new one did not and left the
    > supply unused.
    >
    > The Qualcomm UFS phy bindings were also migrated to newer ones and
    > dropped support for vddp-ref-clk regulator in commit dc5cb63592bd
    > ("dt-bindings: phy: migrate QMP UFS PHY bindings to
    > qcom,sc8280xp-qmp-ufs-phy.yaml").
    >
    > It turns out that this regulator, although with inaccurate name
    > vddp-ref-clk, is actually needed to provide supply for VDD_PX10 (or
    > similar, depending on the SoC) used by UFS controller.
    >
    > Bring back handling of this supply by using more appropriate regulator -
    > UFS controller host supply. This also fixes dtbs_check warning:
    >
    > msm8998-fxtec-pro1.dtb: phy@1da7000: 'vddp-ref-clk-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
    >
    > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    > ---
    Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

    Konrad

    \
     
     \ /
      Last update: 2023-09-06 11:45    [W:6.830 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site