Messages in this thread | | | Date | Tue, 5 Sep 2023 23:34:31 +0300 | Subject | Re: [PATCH v2 2/5] dt-bindings: phy: qcom,qmp-usb: Add SDX75 USB3 PHY | From | Dmitry Baryshkov <> |
| |
On 05/09/2023 13:30, Rohit Agarwal wrote: > Add dt-bindings for USB3 PHY found on Qualcomm SDX75. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- > .../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 40 ++++++++++++++++++++-- > 1 file changed, 37 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > index f99fbbc..5725620 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > @@ -20,6 +20,7 @@ properties: > - qcom,qcm2290-qmp-usb3-phy > - qcom,sa8775p-qmp-usb3-uni-phy > - qcom,sc8280xp-qmp-usb3-uni-phy > + - qcom,sdx75-qmp-usb3-uni-phy
I think the ident is wrong here.
> - qcom,sm6115-qmp-usb3-phy > > reg: > @@ -38,9 +39,7 @@ properties: > maxItems: 2 > > reset-names: > - items: > - - const: phy > - - const: phy_phy > + maxItems: 2 > > vdda-phy-supply: true > > @@ -75,6 +74,7 @@ allOf: > contains: > enum: > - qcom,ipq9574-qmp-usb3-phy > + - qcom,sdx75-qmp-usb3-uni-phy > then: > properties: > clock-names: > @@ -122,6 +122,40 @@ allOf: > required: > - power-domains > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,ipq9574-qmp-usb3-phy > + - qcom,qcm2290-qmp-usb3-phy > + - qcom,sa8775p-qmp-usb3-uni-phy > + - qcom,sc8280xp-qmp-usb3-uni-phy > + - qcom,sm6115-qmp-usb3-phy > + then: > + properties: > + resets: > + maxItems: 2 > + reset-names: > + items: > + - const: phy > + - const: phy_phy > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,sdx75-qmp-usb3-uni-phy > + then: > + properties: > + resets: > + maxItems: 2 > + reset-names: > + items: > + - const: phy > + - const: common
Could you please point us to the actual DTS patch adding this PHY? I'd say, it is highly likely that you are trying to bring in the unnecessary change.
> + > additionalProperties: false > > examples:
-- With best wishes Dmitry
| |