Messages in this thread | | | Date | Tue, 5 Sep 2023 11:12:48 +0200 | From | Lukasz Majewski <> | Subject | Re: [PATCH v3 RFC 4/4] net: dsa: hsr: Provide generic HSR ksz_hsr_{join|leave} functions |
| |
Hi Vladimir,
> On Mon, Sep 04, 2023 at 02:02:09PM +0200, Lukasz Majewski wrote: > > This patch provides the common KSZ (i.e. Microchip) DSA code with > > support for HSR aware devices. > > > > To be more specific - generic ksz_hsr_{join|leave} functions are > > provided, now only supporting KSZ9477 IC. > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > --- > > Changes for v2: > > - None > > > > Changes for v3: > > - Do not return -EOPNOTSUPP for only PRP_V1 (as v2 will not be > > caught) --- > > drivers/net/dsa/microchip/ksz_common.c | 69 > > ++++++++++++++++++++++++++ 1 file changed, 69 insertions(+) > > > > diff --git a/drivers/net/dsa/microchip/ksz_common.c > > b/drivers/net/dsa/microchip/ksz_common.c index > > 579fde54d1e1..91d1acaf4494 100644 --- > > a/drivers/net/dsa/microchip/ksz_common.c +++ > > b/drivers/net/dsa/microchip/ksz_common.c @@ -16,6 +16,7 @@ > > #include <linux/etherdevice.h> > > #include <linux/if_bridge.h> > > #include <linux/if_vlan.h> > > +#include <linux/if_hsr.h> > > #include <linux/irq.h> > > #include <linux/irqdomain.h> > > #include <linux/of_mdio.h> > > This conflicts with commit f44a90104ee5 ("net: dsa: Explicitly include > correct DT includes") from July, merged through net-next. > > "New features" material for networking goes through this tree, please > submit patches that were formatted (and tested) on top of the most > recent version of the "main" branch, and use git-send-email > --subject-prefix "[RFC PATCH vN net-next]" to denote that. > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/log/ > > If patches fail to apply to the target kernel, you lose the benefit of > automatic build testing (which would have highlighted a problem that > exists since v3). With RFC patches, the kbuild test robot sends build > breakage reports only to you - with normal patches it sends them to > everybody.
Thanks for the info.
> > Please wait for more feedback before posting RFC v5. I will review in > more detail, but it will take some time.
Ok. I will wait for your feedback and then sent RFC v4.
> > Thanks.
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de [unhandled content-type:application/pgp-signature] | |