Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 5 Sep 2023 12:12:58 -0700 | Subject | Re: [RFC PATCH 04/10] drm/panel_helper: Introduce drm_panel_helper |
| |
Hi,
On Tue, Sep 5, 2023 at 9:45 AM Doug Anderson <dianders@chromium.org> wrote: > > As per our discussion, in V2 we will make drm_panel_remove() actually > unprepare / disable a panel if it was left enabled. This would > essentially fold in the drm_panel_helper_shutdown() from my RFC patch. > This would make tdo_tl070wsh30_panel_remove() behave the same as it > did before. Ugh, though I may have to think about this more when I get > to implementation since I don't think there's a guarantee of the > ordering of shutdown calls between the DRM driver and the panel. > Anyway, something to discuss later.
Ugh, ignore the above paragraph. I managed to confuse myself and was thinking about shutdown but talking about remove. Sigh. :( Instead, pretend the above paragraph said:
As per our discussion, in V2 we will make drm_panel_remove() actually unprepare / disable a panel (and print a warning) if it was left enabled. This would essentially fold in the drm_panel_helper_shutdown() from my RFC patch (but add a warning). This would make tdo_tl070wsh30_panel_remove() behave the same as it did before with the addition of a warning if someone tries to remove a currently powered panel.
-Doug
| |