Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Tue, 5 Sep 2023 10:36:42 +0200 | Subject | Re: [PATCH 1/2] gpiolib: rename gpio_set_debounce_timeout() for consistency |
| |
On Mon, Sep 4, 2023 at 11:25 AM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Sep 04, 2023 at 09:34:09AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > All other functions that manipulate a struct gpio_desc use the gpiod_ > > prefix. Follow this convention and rename gpio_set_debounce_timeout() to > > gpiod_set_debounce_timeout(). > > No, that's not true. This one is inline with the other gpio_set() _internal_ > APIs. If renamed, should be done consistently. >
All the other ones are static to gpiolib.c. With static symbols the naming convention is a bit more relaxed throughout the kernel. But I do agree and I will get to them in time. :)
Bart
| |