Messages in this thread | | | From | Namhyung Kim <> | Date | Tue, 5 Sep 2023 11:23:28 -0700 | Subject | Re: [PATCH v1 3/3] perf completion: Support completion of metrics/metricgroups |
| |
On Tue, Sep 5, 2023 at 11:16 AM Ian Rogers <irogers@google.com> wrote: > > Allow metrics to expand for -M or --metrics options. > > Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks, Namhyung
> --- > tools/perf/perf-completion.sh | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/perf/perf-completion.sh b/tools/perf/perf-completion.sh > index 319ad724b97a..f224d79b89e6 100644 > --- a/tools/perf/perf-completion.sh > +++ b/tools/perf/perf-completion.sh > @@ -202,6 +202,10 @@ __perf_main () > $prev_skip_opts == @(record|stat|top) ]]; then > local evts=$($cmd list --raw-dump pfm) > __perfcomp "$evts" "$cur" > + elif [[ $prev == @("-M"|"--metrics") && > + $prev_skip_opts == @(stat) ]]; then > + local metrics=$($cmd list --raw-dump metric metricgroup) > + __perfcomp "$metrics" "$cur" > else > # List subcommands for perf commands > if [[ $prev_skip_opts == @(kvm|kmem|mem|lock|sched| > -- > 2.42.0.283.g2d96d420d3-goog >
| |