Messages in this thread | | | Date | Tue, 5 Sep 2023 09:41:23 -0700 | Subject | Re: [PATCH v5 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array | From | Reinette Chatre <> |
| |
Hi Ilpo,
On 9/4/2023 2:53 AM, Ilpo Järvinen wrote: > Benchmark command is copied into an array in the stack. The array is > BENCHMARK_ARGS items long but the command line could try to provide a > longer command. Argument size is also fixed by BENCHMARK_ARG_SIZE (63 > bytes of space after fitting the terminating \0 character) and user > could have inputted argument longer than that. > > Return error in case the benchmark command does not fit to the space > allocated for it. > > Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test") > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> > Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com> > Reviewed-by: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |