Messages in this thread | | | Date | Tue, 5 Sep 2023 16:18:50 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 2/3] i2c: rcar: introduce Gen4 devices |
| |
On Tue, Sep 05, 2023 at 01:36:24PM +0200, Andi Shyti wrote: > Hi Wolfram, > > > @@ -1031,10 +1021,12 @@ static const struct of_device_id rcar_i2c_dt_ids[] = { > > { .compatible = "renesas,i2c-r8a7794", .data = (void *)I2C_RCAR_GEN2 }, > > { .compatible = "renesas,i2c-r8a7795", .data = (void *)I2C_RCAR_GEN3 }, > > { .compatible = "renesas,i2c-r8a7796", .data = (void *)I2C_RCAR_GEN3 }, > > + /* S4 has no FM+ bit */ > > + { .compatible = "renesas,i2c-r8a779f0", .data = (void *)I2C_RCAR_GEN3 }, > > is this I2C_RCAR_GEN3 or I2C_RCAR_GEN4?
Technically, it is Gen4. But its I2C controller behaves like Gen3. This is why it has a seperate entry to avoid the generic Gen4 fallback...
> > - { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN3 }, > > + { .compatible = "renesas,rcar-gen4-i2c", .data = (void *)I2C_RCAR_GEN4 },
... here.
[unhandled content-type:application/pgp-signature] | |