Messages in this thread | | | Date | Tue, 5 Sep 2023 10:35:28 -0500 | From | Rob Herring <> | Subject | Re: [RFC PATCH v3 1/7] dt-bindings: arm: coresight-tmc: Add "memory-region" property |
| |
On Mon, Sep 04, 2023 at 09:26:49AM +0100, Suzuki K Poulose wrote: > On 04/09/2023 06:05, Linu Cherian wrote: > > memory-region 0: Reserved trace buffer memory > > > > TMC ETR: When available, use this reserved memory region for > > trace data capture. Same region is used for trace data > > retention after a panic or watchdog reset. > > > > TMC ETF: When available, use this reserved memory region for > > trace data retention synced from internal SRAM after a panic or > > watchdog reset. > > > > memory-region 1: Reserved meta data memory > > > > TMC ETR, ETF: When available, use this memory for register > > snapshot retention synced from hardware registers after a panic > > or watchdog reset. > > Instead of having to use a number to map the memory regions, could > we use > > memory-region-names property to describe the index ? That way it > is much easier to read and is less error prone.
You can, but the order should still be defined.
> Names could be something like: > > tmc-reserved-trace > tmc-reserved-metadata
Names are local to the binding. So 'tmc' is redundant. And everything is a reserved region for 'memory-region', so that's redundant too.
Rob
| |